Change camGeom stuff to work after DM-5922 changes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
requested changes
Sep 19, 2017
python/lsst/obs/base/yamlCamera.py
Outdated
| focalPlaneToFieldAngle = afwGeom.makeRadialTransform(radialCoeffs) | ||
| fieldAngleToFocalPlane = focalPlaneToFieldAngle.getInverse() | ||
| cameraTransformMap = cameraGeom.TransformMap(cameraGeom.FOCAL_PLANE, | ||
| {cameraGeom.FIELD_ANGLE: fieldAngleToFocalPlane}) |
There was a problem hiding this comment.
Each transform in the dict should transform from the reference coordinate system (FOCAL_PLANE) to the dict key (FIELD_ANGLE in this case. The old code was incorrect and you can trivially make the new code correct by eliminating the line that makes constructs fieldAngleToFocalPlane and using focalPlaneToFieldAngle here.
There was a problem hiding this comment.
No problem, not your fault at all; as you say, this code does indeed have no unit tests. DM-11924 exists to address that (and the introduction of ci_ctio0m9 will also help).
mfisherlevine
force-pushed
the
tickets/DM-11911
branch
2 times, most recently
from
804e385
to
b55f4df
Compare
mfisherlevine
force-pushed
the
tickets/DM-11911
branch
from
b55f4df
to
8706e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.