Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mappers for qa-plot parquet tables #69

Merged
merged 2 commits into from Oct 2, 2017
Merged

Conversation

timothydmorton
Copy link
Contributor

The QA plots need (for now) to write parquet tables of the summarized source catalogs. This defines the filenames for those tables. I'm not sure whether it's OK to have qaTableVisit defined here with a blank template as I do, with then only template defined in obs_subaru, but maybe @PaulPrice can confirm?

Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check what other TextStorage entries do for python --- I'm not sure __builtin__.str works under py3.

@timothydmorton
Copy link
Contributor Author

Good question...I see that FocusSweepPlot in obs_subaru uses builtins.str; is that better? I don't see any other TextStorage entries in obs_base.

@timj
Copy link
Member

timj commented Sep 27, 2017

builtins.str is what you would use in Python3 or Python2+future. This has to work in Python3.

@jdswinbank
Copy link
Contributor

__builtin__.str definitely fails on Py3. @sr525 figured out yesterday that builtins.str seems to be the right way to go.

@timothydmorton
Copy link
Contributor Author

OK, I'll switch the others in obs_subaru to use builtins.str as well; this will save @sr525 having to dig that up in order to make pipe_analysis py3-compatible.

@jdswinbank
Copy link
Contributor

lsst/obs_subaru@fda5411 :-)

@timothydmorton timothydmorton merged commit 5f60c8c into master Oct 2, 2017
@ktlim ktlim deleted the tickets/DM-12030 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants