DM-12041: CameraMapper: fix identification of recipe overrides #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Nov 9, 2017
python/lsst/obs/base/cameraMapper.py
Outdated
| if intersection: | ||
| raise RuntimeError("Recipes provided in %s section %s may not override those in %s: %s" % | ||
| (supplementsFile, entry, recipesFile, intersection)) | ||
| recipes.update(supplements) | ||
|
|
||
| self._writeRecipes = {} | ||
| validationMenu = {'FitsStorage': validateRecipeFitsStorage, } |
There was a problem hiding this comment.
Can you delete this line now that you have inserted a copy before if os.path.exists...?
The test is currently being done at the level of the storage type, but it should be done one level below that (because our compression recipes are appropriate for the same storage type for which other compression recipes are defined, and that's how it should be).
PaulPrice
force-pushed
the
tickets/DM-12041
branch
from
b0e73c0
to
5ffe6a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is currently being done at the level of the storage type, but it
should be done one level below that (because our compression recipes are
appropriate for the same storage type for which other compression recipes
are defined, and that's how it should be).