DM-12599: Implement lossless FITS compression #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Nov 13, 2017
policy/writeRecipes.yaml
Outdated
| @@ -40,3 +40,6 @@ FitsStorage: | |||
| variance: | |||
| <<: *lossyBasic | |||
|
|
|||
| # Set the default | |||
| default: | |||
| <<: *default | |||
There was a problem hiding this comment.
Oh, one quick thing. This is fine, but you might think about whether each of the full-Exposure schemes should be named more explicitly with an & tag, and then default could refer to the full-Exposure scheme rather than moving &default around.
PaulPrice
force-pushed
the
tickets/DM-12599
branch
from
9c5f97a
to
2c3403d
Compare
Give everything a symbolic name, and then just set the default to that. This allows the default to be changed more simply, and gives a symbolic name to the default besides just "default".
Following adoption of RFC-378, lossless compression is to be the default.
PaulPrice
force-pushed
the
tickets/DM-12599
branch
from
2c3403d
to
79c66b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.