Pull request for DM-1195 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based largely on the same utility in obs_lsstSim. Maybe we should make a camera agnostic version of this, but I don't know where it would go.
Removed unused imports and added an import for shutil used but never imported.
There was on off by one error in the previous version. To fix this, check if there is a prescan or overscan region. Add a zero extent bounding box if they do not exist. Also switched to using extents. I think that's safer and easier to read.
Removed blank line in genCameraRepository.py Made displayCamera.py executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a utility to display parts of the camera. Also fixes an off by one error in the amp bounding boxes when they are zero extent.