Review for DM-2837 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def testColorterms(self): | ||
| """Test that the colorterm libraries are formatted correctly""" | ||
| refBands = ["u", "g", "r", "i", "z"] | ||
| cfhtBands = ["u","g","r","i","z"] |
There was a problem hiding this comment.
Try to be consistent with spacing (I, and some PEP8 tools, prefer space after comma in sequences).
There was a problem hiding this comment.
Also, why have both refBands and cfhtBands? If both are needed (because one is modified later), and if both are supposed to be equal, why not make this clear with cfhtBands = refBands[:]
AstroVPK
force-pushed
the
tickets/DM-2837
branch
6 times, most recently
from
f65b0ee
to
5fdf73d
Compare
This commit adds a simple unittest to check that colorterms for CFHT override correctly. The unittest ensures that 1. The colorterms provided in config/colorterms.py are formatted correctly, and 2. The actual values read in match the values in config/colorterms.py for a given filter.
AstroVPK
force-pushed
the
tickets/DM-2837
branch
from
5fdf73d
to
01f50ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple unittest to check that colorterms for
CFHT override correctly. The unittest ensures that
correctly, and
for a given filter.