Tickets/dm 5503 #16
Merged
Tickets/dm 5503 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Sep 29, 2016
|
|
||
| class MakeMegacamRawVisitInfo(MakeRawVisitInfo): | ||
| """Make a VisitInfo from the FITS header of a raw Megacam image | ||
| """ |
There was a problem hiding this comment.
Supposed to have a blank line after class docstring.
| @@ -124,8 +159,6 @@ def testPackageName(self): | |||
| name = dafPersist.Butler.getMapperClass(root=self.repoPath).packageName | |||
| self.assertEqual(name, "obs_cfht") | |||
|
|
|||
| #-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- | |||
|
|
|||
|
|
|||
| def suite(): | |||
There was a problem hiding this comment.
Would you mind upgrading this to support pytest while you're here?
and update testButler to make sure it works
and manually fix a few lines that needed more
Add `from __future__ import absolute_import, division, print_function` to every python module, or in one case move it to standard location
r-owen
force-pushed
the
tickets/DM-5503
branch
from
8372b0e
to
8e42247
Compare
|
I implemented your suggestions, ran autopep8 on all the python code and added the standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.