DM-10765: Replace existing WCS classes with SkyWcs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Jan 8, 2018
python/lsst/obs/cfht/cfhtIsrTask.py
Outdated
| @@ -37,7 +37,7 @@ def run(self, ccdExposure, bias=None, linearizer=None, dark=None, flat=None, def | |||
| @param[in] defects -- list of detects | |||
| @param[in] fringes -- exposure of fringe frame or list of fringe exposure | |||
| @param[in] bfKernel - kernel used for brighter-fatter correction; currently unsupported | |||
| \param[in] camera -- camera geometry, an lsst.afw.cameraGeom.Camera; | |||
| @param[in] camera -- camera geometry, an lsst.afw.cameraGeom.Camera; | |||
| used by addDistortionModel | |||
There was a problem hiding this comment.
Squash with previous commit (where it was introduced) and fix alignment.
There was a problem hiding this comment.
I squashed, but am keeping the alignment as it seems quite common in our code.
r-owen
force-pushed
the
tickets/DM-10765
branch
from
21c934f
to
157351a
Compare
because ip.isr.IsrTask now requires it
instead of the deprecated lsst.afw.image.readMetadata
r-owen
force-pushed
the
tickets/DM-10765
branch
from
157351a
to
2f0e66a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.