obs_cfht review for DM-1945: tasks for multi-band coadd processing #4
Conversation
|
Looks like the first and third commits here should be squashed. |
| "forcedPhotCoadd"): | ||
| path = os.path.join(getPackageDir("obs_cfht"), "config", sub + ".py") | ||
| if os.path.exists(path): | ||
| getattr(root, sub).load(path) |
There was a problem hiding this comment.
I don't think we need this config file (we do need the other two), at least not yet - it's for the multiBand.py driver we're not porting over yet, because it relies on hscPipeBase features we're not porting over yet.
|
Let's pretend I've made the exact same comments on obs_lsstSim (and then I won't have to open a new PR for that). |
|
...same for obs_sdss. In obs_subaru, I don't think we want to squash anything, because they're cherry-picks. And it's probably not worth the effort to remove |
|
Yeah, I was in the "conserve history" mode when I decided not to squash those two commits. They come in as two on obs_subaru from the HSC history, so I thought it best to "history-match" where possible in the other camera packages. I can also see an argument for squashing, so am happy to do that if you prefer? |
|
Yeah, I think squashing is preferable for the non-subaru obs* packages. |
laurenam
force-pushed
the
u/lauren/DM-1945
branch
from
c45faf1
to
2428a19
Compare
No description provided.