DM-21860: Add Gen3 support to obs_cfht #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-21860
branch
from
7dab0a5
to
fc30313
Compare
boutigny
reviewed
Sep 11, 2020
python/lsst/obs/cfht/rawFormatter.py
Outdated
|
|
||
|
|
||
| class MegaPrimeRawFormatter(FitsRawFormatterBase): | ||
| """Gen3 Butler Formatters for HSC raw data. |
There was a problem hiding this comment.
I guess it is MegaPrime instead of HSC
boutigny
reviewed
Sep 11, 2020
| @@ -41,6 +46,34 @@ | |||
| } | |||
There was a problem hiding this comment.
It doesn't look consistent with d63ccc4 some filters are missing (the narrow band ones)
There was a problem hiding this comment.
Correct. That's the gen2 list. I was trying not to mess with the gen2 code paths.
Currently have to use numbered abstract filters since afwFilter does not allow two u filters.
timj
force-pushed
the
tickets/DM-21860
branch
from
d4ab4fa
to
1f984fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently creates an
MegaPrimeinstrument and a very simple raw formatter. I canbutler ingest-rawssuccessfully and I have checked that the gen2 WCS and gen3 WCS from raws agree (although gen2raw_wcsseems to be broken and inconsistent -- works fine if I get therawand then get thewcs).