DM-25807: Suppress known deprecated Filter calls #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Feb 18, 2021
| # surpress Filter warnings; we already know this is deprecated | ||
| warnings.simplefilter('ignore', category=FutureWarning) | ||
| if len(afwImageUtils.Filter.getNames()) >= 2**MegacamMapper._nbit_filter: | ||
| raise RuntimeError("You have more filters defined than fit into the %d bits allocated" % |
There was a problem hiding this comment.
Please don't use % based formatting
There was a problem hiding this comment.
I don't want to modify the existing code, it just got tabbed-in one level due to the added context manager.
There was a problem hiding this comment.
That's fair, not worth 2 commits, and might be confusing on one
natelust
approved these changes
Feb 18, 2021
|
Sorry. I didn't know there was another ticket for it and they were annoying me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this as part of DM-25807 because the extra warnings from obs_cfht in jointcal were making it harder to debug those tests.