Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-29266: Deprecate specialist gen3 raw ingest task #86

Merged
merged 1 commit into from Mar 23, 2021
Merged

Conversation

timj
Copy link
Member

@timj timj commented Mar 19, 2021

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from a mix-up in the version numbers.

python/lsst/obs/cfht/ingest.py Outdated Show resolved Hide resolved
class MegaPrimeRawIngestTask(lsst.obs.base.RawIngestTask):
"""Task for ingesting raw MegaPrime multi-extension FITS data into Gen3.
"""
def extractMetadata(self, filename: ButlerURI) -> RawFileData:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have an explicit pass for readability?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python doesn't require it. The pass seems superfluous to me.

@timj timj merged commit 16268b8 into master Mar 23, 2021
@timj timj deleted the tickets/DM-29266 branch March 23, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants