DM-4813: Skip obs_cfht butler mapper test if datadir isn't found. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct answer is to explicitly skip the tests rather than just returning (implicitly None) from each function.
Use utils.getPackageDir to obtain package path for `testdata_cfht` If it's not there, raise unittest.SkipTest This will cause the tests in the CFHT Butler test suite to be skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip tests in Butler mapper test suite by raising unittest.SkipTest if
testdata_cfhtisn't set up.This then skips the full set of butler+mapping tests in that testing suite.
The availability of
testdata_cfhtis tested withutils.getPackageDir.