Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-19382: Update test value for interpolation changes. #108

Merged
merged 1 commit into from May 29, 2019

Conversation

czwa
Copy link
Contributor

@czwa czwa commented May 21, 2019

Previously, masking and interpolation was done on a by-defect-type
basis: a set of bad pixels were masked and interpolated, then the
process repeated on different bad pixels. However, this ignores the
case where different types of bad pixels may be contiguous, resulting
in interpolated pixels being derived based on previously interpolated
values.

After reordering, unit test check values are slightly different.

@czwa czwa requested a review from ctslater May 21, 2019 20:38
@RobertLuptonTheGood
Copy link
Member

I don't understand this. The last time I looked at the interpolation code (defects and bleed columns) the code very carefully handles neighbouring defects. Did this get removed at some point?

Update test value due to interpolation changes.
@czwa czwa merged commit 17effbf into master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants