DM-22655: Genericize gen2to3.py to be useable with any gen2 repo #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-22655
branch
6 times, most recently
from
f40779d
to
50adb1a
Compare
timj
approved these changes
Mar 5, 2020
This is to improve gen3 conversion compatibility: `subfilters` are `int` (%d) where they are used in the obs_base mappers, so the change here enforces requirement that all keys be the same type in gen3 (they should be in gen2, but it isn't enforced well).
The test requires that ap_verify_ci_hits2015 is setup: not making it a `setupOptional` requirement yet, as it is 4GB in size.
parejkoj
force-pushed
the
tickets/DM-22655
branch
from
50adb1a
to
4697c2f
Compare
This test will not run as part of regular CI because ap_verify_ci_hits2015 is not in lsst_distrib due to size, but at least it gives us a way to run tests relatively easily.
parejkoj
force-pushed
the
tickets/DM-22655
branch
from
3cfd8ba
to
7e2f0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.