DM-23616: Run converted ap_verify testdata through gen3 pipeline #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows runs of CharacterizeImageTask to take advantage of DECam defaults without affecting runs of ProcessCcdTask.
This allows runs of CalibrateTask to take advantage of DECam defaults without affecting runs of ProcessCcdTask.
This was referenced Mar 25, 2020
Merged
parejkoj
approved these changes
Mar 26, 2020
| @@ -0,0 +1,20 @@ | |||
| """ | |||
| DECam-specific overrides for CalibrateTask | |||
There was a problem hiding this comment.
Thank you for this header docstring. All our config specializations should have this.
kfindeisen
commented
Mar 26, 2020
The override was proactively added on DM-11521 for backward-compatibility, but was never actually used (because all DECam processing used the CP config). We don't want historical overrides that aren't actually justified by DECam-specific needs.
The config was once needed to correctly process data with CP calibrations, but the standard IsrTask now handles this case correctly. Having two config files for ProcessCcd has led to some bit rot and is best avoided.
The config file now sets both Gen 2-style config names (which are read by runDataRef) and Gen 3-style connections, ensuring they are equal (which is not validated by IsrTask).
The previous version of the string printed literal whitespace at unexpected points.
kfindeisen
force-pushed
the
tickets/DM-23616
branch
from
a98b265
to
c69408c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
obs_decamconfiguration files to be appropriate for Gen 3. It also performs some general cleanup inspired by discussion on#dm-alert-prod.