Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26327: Flip WCS in X for Gen3 #165

Merged
merged 1 commit into from Aug 18, 2020
Merged

DM-26327: Flip WCS in X for Gen3 #165

merged 1 commit into from Aug 18, 2020

Conversation

timj
Copy link
Member

@timj timj commented Aug 18, 2020

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, otherwise looks good.

@@ -51,6 +51,11 @@ class DarkEnergyCameraRawFormatter(FitsRawFormatterBase):
translatorClass = astro_metadata_translator.DecamTranslator
filterDefinitions = DarkEnergyCamera.filterDefinitions

# DECam has a coordinate system flipped on X with respect to our
# VisitInfo definition of the field angle orientation.
# We have to override this method until RFC-605 is implemented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A class attribute, not a method...

@timj timj merged commit e998c5c into master Aug 18, 2020
@timj timj deleted the tickets/DM-26327 branch August 18, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants