Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-26554: Use decam ISR configs for bias and flat construction #166

Merged
merged 1 commit into from Sep 2, 2020

Conversation

isullivan
Copy link
Contributor

The config settings set in config/isr.py were used correctly in processCcd.py, but were not used for constructBias.py or constructFlat.py. This was not a problem for processing that used the Decam community pipeline calibrations, but resulted in the incorrect processing of the master bias in particular.

The defaults in config/isr.py also turn on and apply settings that are incorrect for constructing the master bias or flat, so I explicitly disabled these in a separate commit.

Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the dark.py and fringe.py config files be updated as well? I see that regular DECam processing doesn't use a dark, but it still may be helpful to keep them up-to-date.

config/flat.py Outdated Show resolved Hide resolved
@isullivan isullivan merged commit 199c894 into master Sep 2, 2020
@isullivan isullivan deleted the tickets/DM-26554 branch September 2, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants