Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23985: Cannot do linearity corrections in Gen 3 DECam processing #176

Merged
merged 3 commits into from Mar 6, 2021
Merged

DM-23985: Cannot do linearity corrections in Gen 3 DECam processing #176

merged 3 commits into from Mar 6, 2021

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Jan 27, 2021

Create gen3 linearizers.

This involves wrapping the gen2 table data in the calibration class.

@czwa czwa requested a review from mrawls January 28, 2021 21:50
mrawls
mrawls reviewed Feb 6, 2021
View reviewed changes
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can show isrTask works in both gen2 and gen3 on some real DECam data (and answer my other miscellaneous questions) I'll be happy with this. Bonus points if you're up for adding a DECam-specific test.

decam/makeLinearizer.py Outdated Show resolved Hide resolved
decam/makeLinearizer.py Show resolved Hide resolved
decam/makeLinearizer.py Show resolved Hide resolved
decam/makeLinearizer.py Outdated Show resolved Hide resolved
@czwa czwa merged commit d70ce6f into master Mar 6, 2021
@czwa czwa deleted the tickets/DM-23985 branch March 6, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrawls mrawls mrawls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@czwa @mrawls