Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27833: Enable gen3 inter-chip crosstalk for DECam #177

Merged
merged 3 commits into from Mar 15, 2021
Merged

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Jan 28, 2021

Add updated two-part crosstalk ISR pipeline definitions.

Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions appear necessary, but leave me confused as to how to run IsrTask with DECam and doCrosstalk: True. Let's say I'm trying to run DRP.yaml and I'm attempting to follow best practices by using the obs_package pipeline (which imports from pipe_tasks as appropriate). Right now, obs_decam does have its own DRP.yaml, but it doesn't import any the DECam ISR pipelines. I think I understand that I need to do two pipetask run calls now, but that needs to be much clearer from the pipeline yaml files themselves, please.

pipelines/RunIsrForCrosstalkSources.yaml Outdated Show resolved Hide resolved
pipelines/RunIsrWithCrosstalk.yaml Outdated Show resolved Hide resolved
pipelines/RunIsrForCrosstalkSources.yaml Outdated Show resolved Hide resolved
@czwa czwa requested a review from mrawls March 5, 2021 20:32
@mrawls
Copy link
Contributor

mrawls commented Mar 6, 2021

Thank you! Is it feasible to also edit the (newer than when you started this, I am now realizing 😬 ) DRP.yaml to use the correct DECam ISR pipeline, perhaps with a comment explaining the recommended precursor step?

@czwa
Copy link
Contributor Author

czwa commented Mar 8, 2021

I've updated the DRP.yaml to point at the correct ISR configuration, as well as a comment block that should explain what is required to generate the crosstalk sources.

Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - it's all much clearer now!

@czwa czwa merged commit 5daeb2b into master Mar 15, 2021
@czwa czwa deleted the tickets/DM-27833 branch March 15, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants