New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-27833: Enable gen3 inter-chip crosstalk for DECam #177
Conversation
ae582c6
to
5ce2587
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additions appear necessary, but leave me confused as to how to run IsrTask with DECam and doCrosstalk: True
. Let's say I'm trying to run DRP.yaml
and I'm attempting to follow best practices by using the obs_package pipeline (which imports from pipe_tasks as appropriate). Right now, obs_decam
does have its own DRP.yaml
, but it doesn't import any the DECam ISR pipelines. I think I understand that I need to do two pipetask run calls now, but that needs to be much clearer from the pipeline yaml files themselves, please.
Thank you! Is it feasible to also edit the (newer than when you started this, I am now realizing 😬 ) |
I've updated the DRP.yaml to point at the correct ISR configuration, as well as a comment block that should explain what is required to generate the crosstalk sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - it's all much clearer now!
Add updated two-part crosstalk ISR pipeline definitions.