DM-28439: Converting HiTS2015 repo fails on bad filter #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Mar 24, 2021
|
Agreed on the "overly specific", but I think a more general fix would have required rewriting a large chunk of the converter. 😞 |
This handler can support DECam-style filter aliases and convert them correctly to Gen 3.
kfindeisen
force-pushed
the
tickets/DM-28439
branch
from
ea4da7d
to
2adeebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filter alias handling to DECam's Gen 2 to Gen 3 conversion code. In particular, this allows both
yandYto be recognized as filter names.