DM-33993: Add config overrides to apply extinction to color-color plots #217
Conversation
There was a problem hiding this comment.
I don't know about the conventions in the different files, but is it just a coincidence that the https://github.com/lsst/obs_decam/blob/main/config/extinctionCoeffs.py here in obs_decam uses bands instead of filters? Or are the filters misnamed in obs_decam?
|
I don't think it is coincidence. @leeskelvin added these recently. He's only been running the DRP pipeline on decam data WITH GEN3, so I'm not surprised he skipped over the Gen2 version of these. |
|
Those old ones in obs_subaru might be unnecessary, but I'm not willing to bet @laurenam's wrath on it, and nor am I willing run anything in pipe_analysis to find out for myself. She can delete it when she gets back if she doesn't need it anymore. |
|
It’s correct as it is in the configs. But the comments referring to filter rather than band are incorrect and we’ll want to clear that up. |
|
I can create a ticket to update the DECam extinction bands to filters, if needs be? Or, update the comments instead, if that would be helpful? |
|
These are bands, they should be bands. The comments say they're filters; it's the comments that are incorrect. |
|
No worries. If it's helpful for me to update the comments on a stand-alone ticket, happy to do so. |
|
Alright. I will clear that up on this ticket.
Comments referred to the key as "Bands." I just swapped out the |
No description provided.