DM-5633: Add config and data products #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| for sub in ("mergeCoaddDetections", "measureCoaddSources", "mergeCoaddMeasurements", "forcedPhotCoadd"): | ||
| path = os.path.join(getPackageDir("obs_decam"), "config", sub + ".py") | ||
| if os.path.exists(path): | ||
| getattr(config, sub).load(path) |
There was a problem hiding this comment.
This doesn't need to be addressed here, but I noticed that this same code is in the obs_subaru config override. Does it make sense to push this into the task config? I'm not sure how to do it, but it always worries me to see this much duplicated code.
There was a problem hiding this comment.
This is a feature we need to push up into our framework, somehow, sometime.
There was a problem hiding this comment.
If there's not a ticket, I've asked Hsin-Fang to file one.
There was a problem hiding this comment.
I've filed DM-5712 to add that new feature.
hsinfang
force-pushed
the
tickets/DM-5633
branch
2 times, most recently
from
438ef4b
to
ce4672c
Compare
hsinfang
force-pushed
the
tickets/DM-5633
branch
from
ce4672c
to
7f2b655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for running forcedPhotCcd, coaddDriverTask, and multiBandDriverTask