DM-34516: Make a better DECam skymap #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-34516
branch
2 times, most recently
from
dce752a
to
180b64f
Compare
isullivan
approved these changes
May 23, 2022
config/makeSkyMap.py
Outdated
Comment on lines
6
to
9
| config.skyMap["discrete"].raList = [5.5, 10.7] | ||
| config.skyMap["discrete"].decList = [-0.6, 41.3] | ||
| config.skyMap["discrete"].radiusList = [0.5, 0.8] | ||
| config.skyMap["discrete"].pixelScale = 0.262 |
There was a problem hiding this comment.
Could you add comments with the units of each of these quantities?
There was a problem hiding this comment.
Thanks Ian, appropriate units (degrees and arcsec/pixel) added in comments.
leeskelvin
force-pushed
the
tickets/DM-34516
branch
from
180b64f
to
f085d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.