DM-34863: Update tests and remove gen2 code from obs_decam. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Jul 18, 2022
|
|
||
| def getCrosstalkDir(): | ||
| """Get crosstalk directory in obs package for outputting data.""" | ||
| return os.path.join(getPackageDir('obs_decam'), 'decam', 'crosstalk') |
There was a problem hiding this comment.
I think it's highly likely that you are going to want people to specify an input directory or a glob expanding to all the files rather than expecting the crosstalk files to always be here.
There was a problem hiding this comment.
This is the destination, it just puts them in decam/crosstalk as before.
leeskelvin
reviewed
Jul 20, 2022
| @@ -1,6 +1,5 @@ | |||
| from .version import * | |||
| from .decamMapper import * | |||
|
|
|||
There was a problem hiding this comment.
Does this blank line need to be here?
There was a problem hiding this comment.
Maybe not, but I don't want to mess with the working ticket...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.