Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32940: Remove unnecessary test for butler dataset existence #235

Merged
merged 1 commit into from Jun 7, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jun 2, 2023

tests/test_isr.py Outdated Show resolved Hide resolved
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tests/test_isr.py Outdated Show resolved Hide resolved
The check isn't really testing anything because the butler.get
immediately afterwards will show that the dataset exists.
@timj timj changed the title DM-32940: Use new Butler.exists API rather than datasetExists DM-32940: Remove unnecessary test for butler dataset existence Jun 7, 2023
@timj timj merged commit 5ac366a into main Jun 7, 2023
1 check passed
@timj timj deleted the tickets/DM-32940 branch June 7, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants