Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40230: Remove Note about the resolved DM-30651. #238

Merged
merged 1 commit into from Aug 23, 2023
Merged

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Jul 28, 2023

I've requested 2 reviewers because it's relevant to each of you and I'm nervous without Jenkins, even though this is just a documentation change.

@wmwv wmwv requested review from mrawls and leeskelvin July 28, 2023 16:22
@leeskelvin
Copy link
Contributor

leeskelvin commented Jul 28, 2023

👍 Well spotted! This LGTM!

PS - I have checked that the two config overrides referred to in the removed text are indeed default for DECam, and they appear to be, so I think this legacy text is good to be removed.

PPS - Please do add "DM-40230: " to the beginning of this PR title, in keeping with our recommended style.

Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for updating the docs! I echo Lee's request to explicitly title this PR with the ticket number. Otherwise, good to go.

@wmwv wmwv changed the title Remove Note about the resolved DM-30651. DM-40230: Remove Note about the resolved DM-30651. Jul 31, 2023
@wmwv wmwv merged commit cd84e84 into main Aug 23, 2023
2 checks passed
@wmwv wmwv deleted the tickets/DM-40230 branch August 23, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants