Tickets/dm 5503 #32
Tickets/dm 5503 #32
Conversation
| # Keywords EXPTIME and MJD-OBS are used to set the calib object. | ||
| for kw in ('EXPTIME', 'MJD-OBS', 'DARKTIME'): | ||
| # extra keywords to copy to the exposure | ||
| for kw in ('DARKTIME', ): |
There was a problem hiding this comment.
Why not include darktime in VisitInfo? It's required for the dark correction, and it would be good not to have to grab it from the header in ISR.
| exp.getCalib().setExptime(1.0) | ||
| rawPath = self.map_raw(dataId).getLocations()[0] | ||
| headerPath = re.sub(r'[\[](\d+)[\]]$', "[0]", rawPath) | ||
| md0 = afwImage.readMetadata(headerPath) |
There was a problem hiding this comment.
@hchiang2 should comment here about whether the darks are MEFs or not. I suspect they are not any more.
There was a problem hiding this comment.
This dark is made by pipe_drivers constructDark.py, so no, it's not a MEF.
This is to get the raw header though, and raws are MEFs.
| calib.setFluxMag0(10**(0.4 * md0.get("MAGZERO"))) | ||
| exp.setCalib(calib) | ||
|
|
||
| visitInfo = self._makeRawVisitInfo(md0) |
There was a problem hiding this comment.
Why the underscore on the method name? To me, the underscore says "you should never have to call this method because it's an internal implementation detail", yet you are calling it.
| @@ -191,7 +191,8 @@ def bypass_instcal(self, datasetType, pythonType, butlerLocation, dataId): | |||
| calib = afwImage.Calib() | |||
| calib.setFluxMag0(10**(0.4 * md0.get("MAGZERO"))) | |||
| exp.setCalib(calib) | |||
| visitInfo = self._makeRawVisitInfo(md0) | |||
| exposureId = self._computeCcdExposureId(dataId) | |||
| visitInfo = self._makeRawVisitInfo(md=md0, exposureId=exposureId) | |||
There was a problem hiding this comment.
Squash into previous commit?
| @@ -233,7 +241,11 @@ def std_raw(self, item, dataId): | |||
|
|
|||
| def std_dark(self, item, dataId): | |||
| exp = afwImage.makeExposure(afwImage.makeMaskedImage(item)) | |||
| exp.getCalib().setExptime(1.0) | |||
| rawPath = self.map_raw(dataId).getLocations()[0] | |||
There was a problem hiding this comment.
Would it ever be possible that one tries to get a dark while raw of the same dataId is not available? (problems using map_raw in std_dark? )
There was a problem hiding this comment.
I suppose it is possible, but I think it unlikely. It should not happen during ISR.
r-owen
force-pushed
the
tickets/DM-5503
branch
from
bc21589
to
ab5c6f7
Compare
DecamMapper sets VisitInfo in raw images and instcal images
r-owen
force-pushed
the
tickets/DM-5503
branch
from
ab5c6f7
to
2a01b0d
Compare
|
All suggestions implemented. |
No description provided.