Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify levels in DecamMapper.paf #4

Merged
merged 1 commit into from Sep 23, 2015
Merged

Modify levels in DecamMapper.paf #4

merged 1 commit into from Sep 23, 2015

Conversation

hsinfang
Copy link

Changes to fix the problem of not looping over ccdnum

The values are lists of keys that are not relevant at that level.
ccdnum is a data identifier but not a level.
@hsinfang
Copy link
Author

"ccd" and "side" are not valid data id keys by default. If they are wanted, I probably should also modify decamMapper to update the keys, similar to the bottom of https://dev.lsstcorp.org/trac/ticket/2859

How useful are ID keys "ccd" and "side" in practice? Also I haven't gone far enough to know whether the levels "tract" is useful either.

@PaulPrice
Copy link
Contributor

"ccd" and "side" allowed you to specify, e.g., N4 as ccd=4 side=N. I don't think the CCDs had official integer labels back when I originally wrote obs_decam, but now that it does (http://www.ctio.noao.edu/noao/content/decam-what), they're probably not necessary.

@hsinfang
Copy link
Author

If the ID keys "ccd" and "side" are not very useful now we have ccdnum, I am inclined to not add them to keyDict. One reason is that "ccd" seems to be the default CCD key and used in some default implementation (for example, _getCcdKeyVal() in CameraMapper). Having "ccd" in keyDict might make it more error-prone because an integer is returned instead of no such a key found? Or should I not be concerned about that?

@hsinfang hsinfang merged commit 5fb3889 into master Sep 23, 2015
@ktlim ktlim deleted the tickets/DM-3816 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants