Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-9113: the bias ingestion should not care about the filter #42

Merged
merged 1 commit into from Jan 26, 2017
Merged

DM-9113: the bias ingestion should not care about the filter #42

merged 1 commit into from Jan 26, 2017

Conversation

mrawls
Copy link
Contributor

@mrawls mrawls commented Jan 26, 2017

Use NONE for CP bias, no matter what FILTER header says, so to get
around wrong validity fix with misleading filter headers in bias.

mrawls
mrawls commented Jan 26, 2017
View reviewed changes
Copy link
Contributor Author

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense and also fixes the problem I was having where the ingestCalibs mistakenly found more than one bias image match in the registry. Thanks!

@hsinfang hsinfang force-pushed the tickets/DM-9113 branch 2 times, most recently from 8b04684 to c08dded Compare January 26, 2017 20:35
Ignore filter and use NONE in the registry for bias files
9c71501 
Use NONE for CP bias, no matter what the FILTER header says,
so the validity fix does not get confused by the misleading
filter headers in bias.
@hsinfang hsinfang merged commit 9c71501 into master Jan 26, 2017
@ktlim ktlim deleted the tickets/DM-9113 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mrawls @hsinfang