DM-9313: obs_decam should not call stripWcsKeywords #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
commented
Feb 7, 2017
| @@ -242,12 +240,12 @@ def std_raw(self, item, dataId): | |||
| # from the metadata. Once TPV is supported, the following keyword | |||
| # removal may not be necessary here and would probably be done at | |||
There was a problem hiding this comment.
May you please correct these comments too? These comments were there partially because of the line you removed. My understanding is the previous behavior of afw.image.makeWcs would not modify the input metadata at all if it's PTV. And the behavior has changed now with DM-9298. Now it removes some wcs cards but not PV cards. Is that correct?
There was a problem hiding this comment.
Agreed. Unfortunately the code is still required because although makeWcs strips those PVn_n keywords internally, it does so on a deep copy. I updated the comment accordingly.
`makeWcs` already strips keywords (if asked to do so) and `stripWcsKeywords` is not part of afw's public API.
Use `from __future__ import absolute_import, division, print_function` and check all existing use of division. Fix flake8 warnings. Note: one file uses two undefined variables; I will file a ticket.
r-owen
force-pushed
the
tickets/DM-9313
branch
from
331e3f4
to
a6bd352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.