DM-3766: Add Butler access to calibration data in obs_decam #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-3766
branch
from
7768ac8
to
9f58d82
Compare
| return ccdnum | ||
|
|
||
| def translate_date(self, md): | ||
| """Convert a full DATE-OBS to a mere date or return unknown |
There was a problem hiding this comment.
I think I'd prefer a description along the lines of:
Extract the date as a string in format YYYY-MM-DD from the supplied FITS header. Returns "unknown" if the DATE-OBS header can not be located.
hsinfang
force-pushed
the
tickets/DM-3766
branch
2 times, most recently
from
3b7d918
to
006766f
Compare
| """ | ||
| if md.exists("DATE-OBS"): | ||
| date = md.get("DATE-OBS").strip() | ||
| date = re.search('^(\d\d\d\d-\d\d-\d\d)T', date).group(1) |
There was a problem hiding this comment.
If for some reason the regexp doesn't match I think this will blow up when you try to extract group 1.
There was a problem hiding this comment.
Yes thanks! And it couldn't extract a date in ISO format either. Corrected with try/except.
hsinfang
force-pushed
the
tickets/DM-3766
branch
from
006766f
to
ae4ba49
Compare
| def translate_date(self, md): | ||
| """Extract the date or date-time string in ISO 8601 format | ||
| from the supplied FITS header and return a mere date. | ||
| Return "unknown" if the DATE-OBS header can not be located. |
There was a problem hiding this comment.
Please fix the docs to also indicate that "unknown" will be returned if the header is there but is corrupt.
hsinfang
force-pushed
the
tickets/DM-3766
branch
from
ae4ba49
to
0e47a44
Compare
| if md.exists("DATE-OBS"): | ||
| date = md.get("DATE-OBS") | ||
| try: | ||
| date = re.search('(\d\d\d\d-\d\d-\d\d)', date).group(1) |
There was a problem hiding this comment.
I think the logic might be more obvious if it was something like
found = re.search('(\d....)', date)
if found:
date = found.group(1)
else:
self.log.warn()
date = "unknown"rather than trying and catching.
hsinfang
force-pushed
the
tickets/DM-3766
branch
3 times, most recently
from
02f8bf7
to
74f9fb6
Compare
added 3 commits
October 1, 2015 09:11
Add DecamCalibsParseTask for parsing DECam Community-Pipeline calibration products, including nightly-MasterCal bias/flat from NOAO Archive, and master fringe from CP website. Files from the two sources have different formats (MEF one HDU for each detector, or one single-HDU fits for each detector) and header keywords.
- Add calibration dataset types bias/flat/fringe in policy. - Add methods to standardize them to Exposure. - Add tests to retrieve flat/bias/fringe with Butler.
hsinfang
force-pushed
the
tickets/DM-3766
branch
from
74f9fb6
to
36b969c
Compare
added 3 commits
October 1, 2015 10:34
Otherwise the dry-run option would not work. DM-3668.
hsinfang
force-pushed
the
tickets/DM-3766
branch
from
36b969c
to
99726a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals: