We now obey INHERIT, so PROPOSER should be seen #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Jul 12, 2017
| @@ -85,9 +85,6 @@ def testInstcal(self): | |||
| self.assertAlmostEqual(weather.getAirPressure(), visit229388_info['weath_airPressure']) | |||
| self.assertAlmostEqual(weather.getHumidity(), visit229388_info['weath_humidity']) | |||
|
|
|||
| # Example of metadata which should *not* have been copied from zeroth extension. | |||
| self.assertNotIn("PROPOSER", exp.getMetadata().paramNames()) | |||
There was a problem hiding this comment.
Is there any metadata which should get copied from the zeroth extension?
There was a problem hiding this comment.
I don't know for DECam, but in general yes -- things like OBS-DATE and EXPTIME tend to be in the PDU.
There was a problem hiding this comment.
Should we have a test for that then?
There was a problem hiding this comment.
Probably, but we also need to remove the special-case code someone added to obs_decam to work around this bug. So I'll defer the testing to that ticket (DM-11264)
There was a problem hiding this comment.
Ok. That's probably all best tested as part of the general set of metadata tests in obs_base (which obs_decam is already partly ported to on DM-7730).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are on afw, this is a fix to a now-incorrect test