DM-11336: Switch default reference catalog for DECam to PS1 in LSST format #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
reviewed
Jul 24, 2017
config/processCcd.py
Outdated
| ): | ||
| refObjLoader.retarget(LoadIndexedReferenceObjectsTask) | ||
| refObjLoader.ref_dataset_name = "ps1_pv3_3pi_20170110" | ||
| refObjLoader.filterMap['u'] = 'g' |
There was a problem hiding this comment.
Are you going to be able to do any useful photometric calibration in u-band? I'm guessing it would require at least adding a color term.
There was a problem hiding this comment.
I do not have any color term data though. In this case is it better to leave out u-band?
There was a problem hiding this comment.
It's a science decision the user would need to make.
There was a problem hiding this comment.
I'm adding a comment here to warn the users.
hsinfang
force-pushed
the
tickets/DM-11336
branch
3 times, most recently
from
4b8d624
to
a3c267e
Compare
Add filterMap for Y-band and u-band Add warnings about u-band; whether the photometric calibration is useful without a color term is up to the science users.
hsinfang
force-pushed
the
tickets/DM-11336
branch
from
a3c267e
to
4aaf49f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.