DM-10765: Replace existing WCS classes with SkyWcs #70
Conversation
r-owen
force-pushed
the
tickets/DM-10765
branch
from
f71595b
to
d635e9a
Compare
tests/nopytest_test_processCcd.py
Outdated
| @@ -87,7 +88,8 @@ def testCcdKey(self): | |||
| def testWcsPostIsr(self): | |||
| """Test the wcs of postISRCCD products | |||
|
|
|||
| The postISRCCD wcs should be the same as the raw wcs with the | |||
| The postISRCCD wcs should be the same as the raw wcs | |||
| after adding camera distortion, and after with the | |||
| for kw in md.paramNames(): | ||
| if re.match(r'PV\d_\d', kw): | ||
| md.remove(kw) | ||
|
|
There was a problem hiding this comment.
Could you comment on this change in the commit message?
There was a problem hiding this comment.
That is an excellent point. I removed it because the new SkyWcs class handles TPV natively, but I'm not actually sure if that's why these were removed. Do you know? If not I'll ask around. Meanwhile I have made it a separate commit so it's easier to spot and easier to ditch if unwanted.
There was a problem hiding this comment.
I believe the TPV keywords broke afw. @RobertLuptonTheGood or @hsinfang will know.
There was a problem hiding this comment.
Thanks Paul...I asked for a comment because I haven’t got a clue!
There was a problem hiding this comment.
We stripped the TPV keywords because wcslib would (correctly) interpret them, but we could not write TPV or easily convert to SIP, and the feeling was that breaking round-tripping in that way was undesirable (DM-3793). There was also an issue where TPV headers would leak from instcals into calexps via HDU 0, and the most expedient way to stop that was by deleting all TPV headers (DM-8042). There is a nominal test for this in testGetInstcal.py, but it might be worth checking a calexp for any inconsistencies.
r-owen
force-pushed
the
tickets/DM-10765
branch
3 times, most recently
from
1c1efe5
to
ff517d8
Compare
because the new WCS class handles TPV natively
since makeSkyWcs strips them. Also stop stripping LTV1, LTV2 as we now ignore them, and stop testing that LTV1, LTV2 are stripped.
instead of the deprecated lsst.afw.image.readMetadata
r-owen
force-pushed
the
tickets/DM-10765
branch
from
fc5b178
to
b554ce4
Compare
No description provided.