DM-11162: Replace all use of Coord and subclasses with SpherePoint #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearmstr
reviewed
Mar 22, 2018
tests/test_getRaw.py
Outdated
|
|
||
|
|
||
| # Desired VisitInfo values for visit 229388, shared between test_getRaw.py and | ||
| # test_getInstcal.py | ||
|
|
||
| boresightRaDec = IcrsCoord('02:51:16.790', '-00:00:05.699') | ||
| boresightRaDec = SpherePoint(42.81995833, -0.00158305, degrees) | ||
| # boresightRaDec = IcrsCoord('02:51:16.790', '-00:00:05.699') |
There was a problem hiding this comment.
Why did you include this line? If you want to preserve the coordinates I don't think it makes sense to put them in a IcrsCoord.
There was a problem hiding this comment.
Agreed. I'll delete it. I was intending to show the sexagesimal representation of the original, but I dooubt it's worth doing, and I should have done it in a less confusing way!
r-owen
force-pushed
the
tickets/DM-11162
branch
from
a287491
to
9609b2b
Compare
Two errors remain: makeCamera.py has two undefined variables as reported in DM-9294
r-owen
force-pushed
the
tickets/DM-11162
branch
from
9609b2b
to
aaf62f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.