DM-16294: clean up dataset type definitions #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Oct 24, 2018
| dcrCoadd_forced_src: | ||
| template: dcrCoadd-results/%(filter)s/%(tract)d/%(patch)s/forced-%(filter)s-%(tract)d-%(patch)s.fits | ||
| dcrCoadd_forced_config: | ||
| template: config/dcrCoadd_forced.py |
There was a problem hiding this comment.
dcrCoadd_measMatch, dcrCoadd_forced_src, and dcrCoadd_forced_metadata should also be deleted.
There was a problem hiding this comment.
dcrCoadd_measMatchFull, too? What's there for that now is not obviously wrong, but it seems unnecessarily different from what's in obs_base:
obs_decam:
dcrCoadd-results/%(filter)s%(subfilter)s/%(tract)d/%(patch)s/srcMatchFull-%(filter)s%(subfilter)s-%(tract)d-%(patch)s.fits
obs_base:
dcrCoadd-results/%(filter)s%(subfilter)dof%(numSubfilters)d/%(tract)d/%(patch)s/srcMatchFull-%(filter)s%(subfilter)dof%(numSubfilters)d-%(tract)d-%(patch)s.fits
There was a problem hiding this comment.
Yes, dcrCoadd_measMatchFull should go too. Sorry I missed it!
I cannot imagine this actually works, as singleFrameDriver no longer runs on full visits and pointing looks like it's probably only valid for HSC.
dcrCoadd_forced_config was present prior to this ticket, and the the others are being added on it.
timj
force-pushed
the
tickets/DM-16294
branch
from
f3767b4
to
759fe02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.