DM-16593: Decam VisitInfo ExposureId set incorrectly #99
Conversation
|
Looking at the comment @hsinfang made on the ticket, it seems as if there are other places where the visitInfo is set from metadata from the header of hdu "0". Will this cause more problems with the data products produced with these functions? It seems to be in the functions |
python/lsst/obs/decam/decamMapper.py
Outdated
| exposureId = self._computeCcdExposureId(dataId) | ||
| visitInfo = self.makeRawVisitInfo(md=md0, exposureId=exposureId) | ||
| visitInfo = self.makeRawVisitInfo(md=md, exposureId=exposureId) |
There was a problem hiding this comment.
I am guessing that the reason the new translator tickled this is that the exposureId passed into the routine is now ignored and is there for backwards compatibility (all the dataId computations will be moved out of obs packages and handled by the metadata translator for gen3).
There was a problem hiding this comment.
Thanks, I hadn't realized it was ignored. I removed the parameter entirely now.
ctslater
force-pushed
the
tickets/DM-16593
branch
from
f1820eb
to
11b2dfc
Compare
This also cleans up a bit of unnecessary code looking in HDU0 for the dark time, a slightly messed up rebase in test_getRaw.py, adds an additional check on fluxMag0 in instcals, and removes the unused exposureId parameter from calls to makeRawVisitInfo.
ctslater
force-pushed
the
tickets/DM-16593
branch
from
11b2dfc
to
02a34f3
Compare
This also cleans up a bit of unnecessary code looking in HDU0 for the dark time,
and what looks like a slightly messed up rebase in test_getRaw.py.