Skip to content

Commit

Permalink
Update expBits used in gen2 to match gen3 value
Browse files Browse the repository at this point in the history
This is required to ensure the source IDs get the same values in both
middlewares. which is desirable in general and, in particular, can
cause different outputs of algorithms making use of the id as an rng
seed.
  • Loading branch information
laurenam committed Jun 21, 2021
1 parent 30368a2 commit 1aa8220
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python/lsst/obs/lsst/imsim.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ImsimMapper(LsstCamMapper):

def bypass_ccdExposureId_bits(self, datasetType, pythonType, location, dataId):
"""How many bits are required for the maximum exposure ID"""
return 38 # max detector_exposure_id ~ 60000000205
return 34 # To match the value computed in gen3


class ImsimParseTask(LsstCamParseTask):
Expand Down
2 changes: 1 addition & 1 deletion python/lsst/obs/lsst/phosim.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class PhosimMapper(LsstCamMapper):

def bypass_ccdExposureId_bits(self, datasetType, pythonType, location, dataId):
"""How many bits are required for the maximum exposure ID"""
return 38 # max detector_exposure_id ~ 60000000205
return 34 # To match the value computed in gen3


class PhosimParseTask(LsstCamParseTask):
Expand Down

0 comments on commit 1aa8220

Please sign in to comment.