Skip to content

Commit

Permalink
Set mag limits for refcat loading in LSSTComCamSim
Browse files Browse the repository at this point in the history
These have been selected to more than span the expected magnitude
range for the icSrc catalog sources (those available for the
calibrations).  Loading in reference sources outside of this range
is undesirable for a few reasons, including wasting time on objects
that are not acutally in contention for matcing and, more importantly,
leaving a danger of the fit getting "lost" by locking onto the
"superfluous" reference catalog objects (we saw this happen in
photoCal for 3 of 25935 dataIds in the first round Ops Rehearsal 3
dataset).
  • Loading branch information
laurenam committed Mar 7, 2024
1 parent 353ecef commit eec7390
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
18 changes: 18 additions & 0 deletions config/comCamSim/calibrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,21 @@
config.photoRefObjLoader.load(os.path.join(configDir, "filterMap.py"))
config.astromRefObjLoader.anyFilterMapsToThis = None
config.photoRefObjLoader.anyFilterMapsToThis = None

# The following magnitude limits for reference objects used in the
# astrometric and photometric calibrations were selected to more than
# span the expected magnitude range of the icSrc catalog sources, i.e.
# those available for the calibrations (see DM-43143 for example
# distributions). This is to avoid passing reference objects to the
# matcher that sould not be in contention for matching (thus reducing
# the chance of locking onto a bad match).
# TODO: remove (or update) once DM-43168 is implemented.
config.astrometry.referenceSelector.doMagLimit = True
config.astrometry.referenceSelector.magLimit.fluxField = "lsst_r_flux"
config.astrometry.referenceSelector.magLimit.minimum = 14.0
config.astrometry.referenceSelector.magLimit.maximum = 22.0

config.photoCal.match.referenceSelection.doMagLimit = True
config.photoCal.match.referenceSelection.magLimit.fluxField = "lsst_r_flux"
config.photoCal.match.referenceSelection.magLimit.minimum = 14.0
config.photoCal.match.referenceSelection.magLimit.maximum = 22.0
18 changes: 18 additions & 0 deletions config/comCamSim/calibrateImage.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,21 @@
config.photometry_ref_loader.load(os.path.join(configDir, "filterMap.py"))
config.astrometry_ref_loader.anyFilterMapsToThis = None
config.photometry_ref_loader.anyFilterMapsToThis = None

# The following magnitude limits for reference objects used in the
# astrometric and photometric calibrations were selected to more than
# span the expected magnitude range of the science sources available
# for the calibrations (see DM-43143 for example distributions). This
# is to avoid passing reference objects to the matcher that sould not
# be in contention for matching (thus reducing the chance of locking
# onto a bad match).
# TODO: remove (or update) once DM-43168 is implemented.
config.astrometry.referenceSelector.doMagLimit = True
config.astrometry.referenceSelector.magLimit.fluxField = "lsst_r_flux"
config.astrometry.referenceSelector.magLimit.minimum = 14.0
config.astrometry.referenceSelector.magLimit.maximum = 22.0

config.photometry.match.referenceSelection.doMagLimit = True
config.photometry.match.referenceSelection.magLimit.fluxField = "lsst_r_flux"
config.photometry.match.referenceSelection.magLimit.minimum = 14.0
config.photometry.match.referenceSelection.magLimit.maximum = 22.0

0 comments on commit eec7390

Please sign in to comment.