Tickets/dm 19256 #104
Merged
Tickets/dm 19256 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Apr 20, 2019
| ----- | ||
| The Gen2 butler can't quite do this natively as it doesn't | ||
| know how to only lookup things that it doesn't know, so we | ||
| so that for it, poor lamb |
|
Why are all of your docstrings prepended with |
parejkoj
reviewed
Apr 20, 2019
| ---------- | ||
| camera : `lsst.afw.cameraGeom.Camera` | ||
| The object describing a/the LSST Camera | ||
| focalPlaneXY : `lsst.afw.geom.PointD` |
There was a problem hiding this comment.
This is a lsst.geom.Point2D?
parejkoj
reviewed
Apr 20, 2019
| if afwGeom.BoxD(detector.getBBox()).contains(ccdXY): | ||
| return detector, ccdXY | ||
|
|
||
| raise RuntimeError("Failed to map focal plane position (%.3f, %.3f) to a detector" % (focalPlaneXY)) |
There was a problem hiding this comment.
This exception message will raise TypeError, because Point2D does not stringify to (%.3f, %.3f)
parejkoj
reviewed
Apr 20, 2019
| pass a detectorName (None to disable the default detectorName) | ||
| """ | ||
| self.camera = camera | ||
| self.__detectorName = detectorName |
There was a problem hiding this comment.
Did you really mean to use double-underscores here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some functionality for SLAC