DM-19728: Ingest defects using standardized system. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
force-pushed
the
tickets/DM-19728
branch
from
bfe2fa5
to
1c34ccd
Compare
plazas
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
It looks good provided it produces a defects file as described in the RFC-595. Simon clarified that the defects are built from the text format at scons time, but they will still need to be ingested in the calibration repository for use by ISR. If the tests pass, then it looks good.
SimonKrughoff
force-pushed
the
tickets/DM-19728
branch
from
1c34ccd
to
c762db5
Compare
SimonKrughoff
force-pushed
the
tickets/DM-19728
branch
from
c762db5
to
9f46369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved also making the new package obs_lsst_data.