Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-19985: add template entry for forcedPhotCcd_metadata #116

Merged
merged 2 commits into from Jun 18, 2019

Conversation

heather999
Copy link
Collaborator

As discussed on JIRA, there are some missing templates. This PR currently addresses forcedPhotCcd_metadata

@wmwv
Copy link
Contributor

wmwv commented Jun 17, 2019

This template could just be specified as

forcedPhotCcd_metadata:
    template: forcedPhotCcd_metadata/%(visit)08d-%(filter)s/%(raftName)s/forcedPhotCcd_metadata_%(visit)08d-%(filter)s-%(raftName)s-%(detectorName)s-det%(detector)03d.yaml

The perisistable, storage, python object, and tables values remain the same as in obs_base.

@wmwv wmwv self-requested a review June 17, 2019 20:07
Copy link
Contributor

@wmwv wmwv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forcedPhotCcd_metadata template specification can just be

forcedPhotCcd_metadata:
    template: forcedPhotCcd_metadata/%(visit)08d-%(filter)s/%(raftName)s/forcedPhotCcd_metadata_%(visit)08d-%(filter)s-%(raftName)s-%(detectorName)s-det%(detector)03d.yaml

The perisistable, storage, python object, and tables values remain the same as in obs_base and so don't need to be repeated.

I notice that there is a mix of (1) redundantly re-specifying these values for other dataset types and (2) not doing so in this policy file, but that can be simplified in a future ticket.

@heather999 heather999 merged commit a7247ac into master Jun 18, 2019
@timj timj deleted the tickets/DM-19985 branch May 12, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants