DM-19329: Add comCam support to obs_lsst #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this it is possible for a subclass to pick up the detector mappings from a parent translator.
| python: lsst.daf.base.PropertyList | ||
| storage: FitsStorage | ||
| tables: raw | ||
| template: raw/%(run)s/%(raftName)s/%(visit)08d-%(raftName)s-%(detectorName)s-det%(detector)03d-%(snap)03d.fits[0] |
There was a problem hiding this comment.
Do we still have the concept of runs for ComCam? Maybe we do. I'm not even sure where this is supposed to support data from, so perhaps this is fine, but I think this was really only a TS8 and TS3 concept. If the data is there in the headers then it's fine though. If not, then here and throughout this file run will need addressing.
There was a problem hiding this comment.
This is a generic obs_lsst gen2 question. lsstCam supports run so surely comCam should to. It gets set to "unknown". If we remove it we should have the broader discussion on lsstCam as well.
There was a problem hiding this comment.
I'm surprise it's needed on lsstCam as well, but if it is, then yes, I agree to leave it.
This reverts commit f487f44. The test data directory includes butler and fits files so we can not ignore all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No butler gen 2 tests yet.