tickets/DM-19709 Add config and dataset for defect finding task #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Aug 7, 2019
| config.isrForDarks.load(os.path.join(getPackageDir("obs_lsst"), "config", "isr.py")) | ||
|
|
||
| config.ccdKey = 'detector' | ||
| config.assertSameRun = True |
There was a problem hiding this comment.
A comment for why this config is set, please?
| config.ccdKey = 'detector' | ||
| config.assertSameRun = True | ||
|
|
||
| for config in [config.isrForDarks, config.isrForFlats]: |
There was a problem hiding this comment.
Please add a comment about why these are disabled here (not for biases?).
There was a problem hiding this comment.
I have commented on why in the code. The "not for biases" part doesn't make sense though - this is the two custom isr tasks for processing the darks and flats to find defects in, so there isn't one for biases.
mfisherlevine
force-pushed
the
tickets/DM-19709
branch
from
1c08500
to
57ce71b
Compare
mfisherlevine
force-pushed
the
tickets/DM-19709
branch
from
57ce71b
to
768dfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.