Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-20524: Add some fixes for DIA analysis #122

Merged
merged 4 commits into from Oct 9, 2019
Merged

DM-20524: Add some fixes for DIA analysis #122

merged 4 commits into from Oct 9, 2019

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Aug 20, 2019

  1. Correct {dcr,deep}Diff_* visit format strings to explicitly be %(visit)08d
  2. Add deepDiff_diaObject, deepDiff_forced_diaSrc, deepDiff_forced_diaObject, deepDiff_diaObjectId and accompanying _schema dataset types.
  3. Adds configs for additional Tasks to support DIA analysis.
    NOTE that these are configs used by LSSTDESC/dia_pipe. While LSSTDESC/dia_pipe is not in the main LSST code base, I hope that we can help develop our way toward very similar things being incorporated in LSST repos -- likely eventually in pipe_tasks.
    forcedPhotCcdDiaDriver_config, forcedPhotCoaddDiaDriver_config, forcedPhotCcdDia_config, forcedPhotCoaddDia_config, imageDifferenceDriver_config, imageDifferenceDriver_metadata, associationDriver_config.

@wmwv wmwv requested review from czwa and yalsayyad August 20, 2019 18:55
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the additional datasets be migrated to the base mapper/other obs_ packages in the future?

Regardless, I don't see any issues in the definitions here.

@timj timj changed the title Tickets/dm 20524 - Add DM-20524: Add some fixes for DIA analysis Sep 18, 2019
@wmwv wmwv merged commit 4a589eb into master Oct 9, 2019
@timj timj deleted the tickets/DM-20524 branch May 12, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants