DM-21187: Reorganize bin scripts so they can be tested #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has not been used since d4ad24f when we switched to a pipe_tasks implementation.
This matches the modern style.
This makes it easier to test
timj
force-pushed
the
tickets/DM-21187
branch
from
027bc12
to
ba4cf4c
Compare
czwa
approved these changes
Sep 10, 2019
|
Sorry. I should have noted that most of the changes are moving code around and not new code at all. |
With the reorganized codebase it is now possible to test the logic in phosimTorafts without having to run the script itself. This also allows code coverage to be tested. The executable test remains but its utility is much less now.
This also fixes the name LATISS and updates the test.
timj
force-pushed
the
tickets/DM-21187
branch
from
ba4cf4c
to
534bac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.