Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-18610: Add fields, limited mutability, and trim/assembly-state tracking to cameraGeom #130

Merged
merged 1 commit into from Nov 4, 2019

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Sep 18, 2019

Reconstruct the amp/detector using builders to allow for BBox changes.

@czwa czwa force-pushed the tickets/DM-18610 branch 2 times, most recently from a40df1b to 5dd0ffc Compare September 24, 2019 19:08
@czwa czwa requested a review from timj September 24, 2019 20:13
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the substantive change to builders but the rest looks fine to me. I assume the expected failing test in test_assemble.py still fails.

python/lsst/obs/lsst/assembly.py Outdated Show resolved Hide resolved
@czwa czwa force-pushed the tickets/DM-18610 branch 2 times, most recently from cec2175 to 659417f Compare October 23, 2019 19:41
@czwa czwa force-pushed the tickets/DM-18610 branch 2 times, most recently from a73308b to 934ef52 Compare October 28, 2019 18:42
@czwa czwa merged commit 85af71a into master Nov 4, 2019
@timj timj deleted the tickets/DM-18610 branch May 12, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants