Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-19903: Add columnar defect identification to findDefectsTask in cp_pipe please #135

Merged
merged 1 commit into from Oct 25, 2019
Merged

DM-19903: Add columnar defect identification to findDefectsTask in cp_pipe please #135

merged 1 commit into from Oct 25, 2019

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Oct 7, 2019

Added correction files to "corrections" directory with missing keywords for auxTel data from 09/27/19

@plazas plazas requested a review from parejkoj October 7, 2019 22:08
parejkoj
parejkoj approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes look fine to me, but they do suggest that we are going to want a better way to handle making corrections to hundreds/thousands of files.

@timj
Copy link
Member

timj commented Oct 15, 2019

The hope is that we improve with time...

@plazas plazas changed the title Added correction files for 09/27/19 auxtel data DM-19903: Add columnar defect identification to findDefectsTask in cp_pipe please Oct 25, 2019
@plazas plazas merged commit 012868b into master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plazas @timj @parejkoj