DM-21981: Update rawFormatter to correctly resize amplifier bboxes. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Nov 8, 2019
| @@ -77,11 +77,41 @@ def readImage(self): | |||
| image : `~lsst.afw.image.Image` | |||
| In-memory image component. | |||
| """ | |||
| return self.readFull().getImage() | |||
|
|
|||
| def readFull(self, parameters=None): | |||
There was a problem hiding this comment.
Should probably document that there are no acceptable parameters for this readFull implementation.
| if variance is not None: | ||
| exposure.setVariance(variance) | ||
|
|
||
| info = exposure.getInfo() |
There was a problem hiding this comment.
Which of these lines fixed the real problem with amplifiers?
There was a problem hiding this comment.
The fix is in not dropping the exposure; the code previously called readImage(), which did all that is now in readFull(), but returned exposure.getImage(). This dropped the updated amplifier information constructed in fixAmpsAndAssemble(), resulting in an image that contained all of the amplifier image data, but without the updated bbox information to find it.
| @@ -57,6 +57,34 @@ def assertAmpRawBBoxesEqual(self, amp1, amp2): | |||
| self.assertEqual(amp1.getRawHorizontalOverscanBBox(), amp2.getRawHorizontalOverscanBBox()) | |||
| self.assertEqual(amp1.getRawVerticalOverscanBBox(), amp2.getRawVerticalOverscanBBox()) | |||
|
|
|||
| def assertAmpRawBBoxesFlippablyEqual(self, amp1, amp2): | |||
This retains updated detector/amplifier bbox information that is lost using the "readImage" method as the foundation.
czwa
force-pushed
the
tickets/DM-21981
branch
from
37da188
to
a515b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.